Skip to content

Conversation

@beardhatcode
Copy link

@beardhatcode beardhatcode commented Feb 20, 2025

I've been trying to build psmpi, but the autogen failed silently, and it took me a while to figure this out.

This pull request includes updates to all autogen.sh scripts across to ensure that the scripts stop on failure. The change is the addition of the set -e command in each script.

sed  -i '/^#/!{s/.*/set -e # stop on failure\n&/;:a;n;ba}' **/autogen.sh 

@sonjahapp
Copy link
Contributor

Hi @beardhatcode! Thanks for this PR and your interest in ParaStation MPI.

Indeed, the autogen should not fail silently. However, the solution that you propose might not solve the actual issue that you have observed. With set -e the autogen will abort if a script has an exit status different from 0. However, an exit status different from 0 does not necessarily mean that a (fatal) error occurred (see e.g. grep). So adding set -e everywhere can lead to undesired side effects during autogen.

What version of psmpi are you using and what is the silent autogen failure that you observed, i.e., where did the autogen fail exactly? These infos could help to narrow down the problem. Perhaps there is something more specific that needs a fix in the autogen script(s).

Just out of curiosity on my side: What is your use case for ParaStation MPI? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants