Moving the _search_time_index function to _index_search.py#1937
Merged
erikvansebille merged 3 commits intov4-devfrom Mar 13, 2025
Merged
Moving the _search_time_index function to _index_search.py#1937erikvansebille merged 3 commits intov4-devfrom
erikvansebille merged 3 commits intov4-devfrom
Conversation
Member
Author
|
@VeckoTheGecko, can you help with fixing the mypy errors? Not sure what is going wrong (and why it wasn't flagged when the same function was still part of field.py...) |
VeckoTheGecko
requested changes
Mar 13, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Small comment, otherwise LGTM! Will fix mypy
VeckoTheGecko
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
Field._search_time_indexmethod to its own function in_index_search.py, where I feel it would fit bettermainfor v3 changes,v4-devfor v4 changes)