Removing fieldtype argument from Field constructor#1942
Removing fieldtype argument from Field constructor#1942erikvansebille merged 3 commits intov4-devfrom
Conversation
As it's more pythonic to attach UnitConverters directly to a field? See also #1883 (comment)
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Minor edits, otherwise LGTM.
Should we be concerned with the naming of
UWind.units = parcels.tools.converters.GeographicPolar()
VWind.units = parcels.tools.converters.Geographic()
? Previously it might have been easier to identify that VWind would be of field type V, whereas now its probably not as clear to the user that it needs a Geographic converter and not a GeographicPolar converter. Perhaps this would just be something to keep an eye on moving forward, that we can revisit the naming/how to specify these unit converters.
|
I also added a setter for |
Good point that these names may be confusing. Maybe the names |
Removing
fieldtypeargument fromFieldconstructor, as it's more pythonic to attach UnitConverters directly to a field?See also #1883 (comment)
mainfor v3 changes,v4-devfor v4 changes)