-
Notifications
You must be signed in to change notification settings - Fork 14
Log filter v2 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Log filter v2 #188
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
89ee96d
log filter class
j-atkins 083ba24
apply log filter to adcp and onboard measurements
j-atkins 2b0c50b
new log filter tool
j-atkins 5debb8a
apply log filtering to each instrument
j-atkins 0b08bc6
add rotating dial class
j-atkins a0da379
add rotating dial to instrument progress monitoring
j-atkins cd9d1b0
update expedition output printing
j-atkins 4dcd312
update test to reflect new do_expedition print statements
j-atkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| """Measurement instrument that can be used with Parcels.""" | ||
|
|
||
| from . import adcp, argo_float, ctd, drifter, ship_underwater_st, xbt | ||
| from . import adcp, argo_float, ctd, ctd_bgc, drifter, ship_underwater_st, xbt | ||
|
|
||
| __all__ = ["adcp", "argo_float", "ctd", "drifter", "ship_underwater_st", "xbt"] | ||
| __all__ = [ | ||
| "adcp", | ||
| "argo_float", | ||
| "ctd", | ||
| "ctd_bgc", | ||
| "drifter", | ||
| "ship_underwater_st", | ||
| "xbt", | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Python, this
tryfinallypattern is normally done via context managers. This means that if something fails in the block of code, the code is torn down after.This will simplify both the code for the spinner, as well as the code for the filtering, boiling down to something like