Merge develop into production — peers audit-fix sprint (50+ findings …#135
Open
Merge develop into production — peers audit-fix sprint (50+ findings …#135
Conversation
…ation tail assertion, set CI env
…with rejectUnauthorized:false Self-signed peer certs cannot be CA-validated, so rejectUnauthorized:true causes Node to reject the handshake before checkServerIdentity runs. Switch back to rejectUnauthorized:false in both peer client paths (peer-http postJsonPinned and ws-transport.dial); pinnedCheckServerIdentity still enforces the fingerprint at TLS time and fails the handshake on mismatch. Also isolate peer-identity tests from CI's ADC_PEERS_ALLOW_PLAINTEXT_IDENTITY env var so the throw-on-unavailable assertions remain meaningful.
…dentity Error when rejectUnauthorized:false); pair-flow waits for connection AFTER pairing populates peerStores
…(notifyDisconnected); was stuck in 'open' state on auth-fail close
…n post-handshake, dialer notifyDisconnected, pair-flow ordering)
…ackaged app on launch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…closed)
What
Why
Changes
Testing
npm run lintpasses cleannpm run typecheckpasses cleannpm run buildsucceedsnpm run dev)Screenshots