Skip to content

only fused-local-corr for linux and make matching params visible#122

Merged
Parskatt merged 2 commits intomainfrom
johan/windows-no-custom-corr
Sep 26, 2025
Merged

only fused-local-corr for linux and make matching params visible#122
Parskatt merged 2 commits intomainfrom
johan/windows-no-custom-corr

Conversation

@Parskatt
Copy link
Owner

@Parskatt Parskatt commented Sep 24, 2025

  1. Only use the fused kernel on linux, so make dep conditional on platform.
  2. Also makes a bunch of params of the matcher visible in the api.

Should fix #121

@Parskatt Parskatt linked an issue Sep 24, 2025 that may be closed by this pull request
@Parskatt
Copy link
Owner Author

@developer0hye could you check if this works for you on windows?

@Parskatt Parskatt mentioned this pull request Sep 24, 2025
@Parskatt
Copy link
Owner Author

Also makes some hparams of matcher available in roma_outdoor / roma_indoor, nicer than manually using setattr

@Parskatt Parskatt changed the title only fused-local-corr for linux only fused-local-corr for linux and make matching params visible Sep 24, 2025
@developer0hye
Copy link

@Parskatt Cool~! Don't forget Window users haha

(pytorch270cu128) PS C:\Users\dt01yhkwon\Documents\Projects\roma\RoMa> pip install -e .
Obtaining file:///C:/Users/dt01yhkwon/Documents/Projects/roma/RoMa
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
Requirement already satisfied: albumentations in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (2.0.8)
Requirement already satisfied: einops in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (0.8.1)
Requirement already satisfied: h5py in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (3.14.0)
Requirement already satisfied: kornia in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (0.8.1)
Requirement already satisfied: loguru in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (0.7.3)
Requirement already satisfied: matplotlib in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (3.10.3)
Requirement already satisfied: opencv-python in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (4.11.0.86)
Requirement already satisfied: poselib>=2.0.4 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (2.0.5)
Requirement already satisfied: timm in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (1.0.16.dev0)
Requirement already satisfied: torch>=2.5.1 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (2.7.0+cu128)
Requirement already satisfied: torchvision in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (0.22.0+cu128)
Requirement already satisfied: tqdm in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (4.67.1)
Requirement already satisfied: wandb in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from romatch==0.1.0) (0.20.1)
Requirement already satisfied: numpy in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from poselib>=2.0.4->romatch==0.1.0) (1.26.4)
Requirement already satisfied: filelock in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from torch>=2.5.1->romatch==0.1.0) (3.13.1)
Requirement already satisfied: typing-extensions>=4.10.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from torch>=2.5.1->romatch==0.1.0) (4.12.2)
Requirement already satisfied: sympy>=1.13.3 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from torch>=2.5.1->romatch==0.1.0) (1.13.3)
Requirement already satisfied: networkx in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from torch>=2.5.1->romatch==0.1.0) (3.3)
Requirement already satisfied: jinja2 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from torch>=2.5.1->romatch==0.1.0) (3.1.6)
Requirement already satisfied: fsspec in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from torch>=2.5.1->romatch==0.1.0) (2024.6.1)
Requirement already satisfied: setuptools in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from torch>=2.5.1->romatch==0.1.0) (78.1.1)
Requirement already satisfied: mpmath<1.4,>=1.1.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from sympy>=1.13.3->torch>=2.5.1->romatch==0.1.0) (1.3.0)
Requirement already satisfied: scipy>=1.10.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from albumentations->romatch==0.1.0) (1.15.2)
Requirement already satisfied: PyYAML in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from albumentations->romatch==0.1.0) (6.0.2)
Requirement already satisfied: pydantic>=2.9.2 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from albumentations->romatch==0.1.0) (2.11.4)
Requirement already satisfied: albucore==0.0.24 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from albumentations->romatch==0.1.0) (0.0.24)
Requirement already satisfied: opencv-python-headless>=4.9.0.80 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from albumentations->romatch==0.1.0) (4.11.0.86)
Requirement already satisfied: stringzilla>=3.10.4 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from albucore==0.0.24->albumentations->romatch==0.1.0) (3.12.5)        
Requirement already satisfied: simsimd>=5.9.2 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from albucore==0.0.24->albumentations->romatch==0.1.0) (6.4.7)
Requirement already satisfied: annotated-types>=0.6.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from pydantic>=2.9.2->albumentations->romatch==0.1.0) (0.7.0)
Requirement already satisfied: pydantic-core==2.33.2 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from pydantic>=2.9.2->albumentations->romatch==0.1.0) (2.33.2)       
Requirement already satisfied: typing-inspection>=0.4.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from pydantic>=2.9.2->albumentations->romatch==0.1.0) (0.4.0)     
Requirement already satisfied: MarkupSafe>=2.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from jinja2->torch>=2.5.1->romatch==0.1.0) (2.1.5)
Requirement already satisfied: kornia_rs>=0.1.9 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from kornia->romatch==0.1.0) (0.1.9)
Requirement already satisfied: packaging in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from kornia->romatch==0.1.0) (25.0)
Requirement already satisfied: colorama>=0.3.4 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from loguru->romatch==0.1.0) (0.4.6)
Requirement already satisfied: win32-setctime>=1.0.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from loguru->romatch==0.1.0) (1.2.0)
Requirement already satisfied: contourpy>=1.0.1 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from matplotlib->romatch==0.1.0) (1.3.2)
Requirement already satisfied: cycler>=0.10 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from matplotlib->romatch==0.1.0) (0.12.1)
Requirement already satisfied: fonttools>=4.22.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from matplotlib->romatch==0.1.0) (4.58.0)
Requirement already satisfied: kiwisolver>=1.3.1 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from matplotlib->romatch==0.1.0) (1.4.8)
Requirement already satisfied: pillow>=8 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from matplotlib->romatch==0.1.0) (11.0.0)
Requirement already satisfied: pyparsing>=2.3.1 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from matplotlib->romatch==0.1.0) (3.2.3)
Requirement already satisfied: python-dateutil>=2.7 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from matplotlib->romatch==0.1.0) (2.9.0.post0)
Requirement already satisfied: six>=1.5 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from python-dateutil>=2.7->matplotlib->romatch==0.1.0) (1.17.0)
Requirement already satisfied: huggingface_hub in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from timm->romatch==0.1.0) (0.30.2)
Requirement already satisfied: safetensors in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from timm->romatch==0.1.0) (0.5.3)
Requirement already satisfied: requests in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from huggingface_hub->timm->romatch==0.1.0) (2.32.3)
Requirement already satisfied: charset-normalizer<4,>=2 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from requests->huggingface_hub->timm->romatch==0.1.0) (3.4.2)
Requirement already satisfied: idna<4,>=2.5 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from requests->huggingface_hub->timm->romatch==0.1.0) (3.10)
Requirement already satisfied: urllib3<3,>=1.21.1 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from requests->huggingface_hub->timm->romatch==0.1.0) (2.4.0)
Requirement already satisfied: certifi>=2017.4.17 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from requests->huggingface_hub->timm->romatch==0.1.0) (2025.4.26)       
Requirement already satisfied: click!=8.0.0,>=7.1 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from wandb->romatch==0.1.0) (8.1.8)
Requirement already satisfied: gitpython!=3.1.29,>=1.0.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from wandb->romatch==0.1.0) (3.1.44)
Requirement already satisfied: platformdirs in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from wandb->romatch==0.1.0) (4.3.8)
Requirement already satisfied: protobuf!=4.21.0,!=5.28.0,<7,>=3.19.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from wandb->romatch==0.1.0) (6.31.0)
Requirement already satisfied: psutil>=5.0.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from wandb->romatch==0.1.0) (7.0.0)
Requirement already satisfied: sentry-sdk>=2.0.0 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from wandb->romatch==0.1.0) (2.30.0)
Requirement already satisfied: setproctitle in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from wandb->romatch==0.1.0) (1.3.6)
Requirement already satisfied: gitdb<5,>=4.0.1 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from gitpython!=3.1.29,>=1.0.0->wandb->romatch==0.1.0) (4.0.12)
Requirement already satisfied: smmap<6,>=3.0.1 in c:\users\dt01yhkwon\.conda\envs\pytorch270cu128\lib\site-packages (from gitdb<5,>=4.0.1->gitpython!=3.1.29,>=1.0.0->wandb->romatch==0.1.0) (5.0.2)
Building wheels for collected packages: romatch
  Building editable for romatch (pyproject.toml) ... done
  Created wheel for romatch: filename=romatch-0.1.0-py3-none-any.whl size=3715 sha256=67b17da77d1dbf83a5a0e6927d86a060747b24fe94887971d7b0cefd7322e65e
  Stored in directory: C:\Users\dt01yhkwon\AppData\Local\Temp\pip-ephem-wheel-cache-7ztvwnc1\wheels\ac\f0\23\7ab94a1d5ba744834d3b7058c3c998ec3137dccfad413bb5f8
Successfully built romatch
Installing collected packages: romatch
Successfully installed romatch-0.1.0
(pytorch270cu128) PS C:\Users\dt01yhkwon\Documents\Projects\roma\RoMa> python .\demo\demo_fundamental.py
C:\Users\dt01yhkwon\Documents\Projects\roma\RoMa\romatch\models\model_zoo\roma_models.py:49: UserWarning: Local correlation is not supported on non-Linux platforms, setting use_custom_corr to False
  warnings.warn("Local correlation is not supported on non-Linux platforms, setting use_custom_corr to False")
2025-09-25 11:00:23.584 | INFO     | romatch.models.model_zoo.roma_models:roma_model:61 - Using coarse resolution (560, 560), and upsample res (864, 864)
C:\Users\dt01yhkwon\Documents\Projects\roma\RoMa\romatch\models\model_zoo\roma_models.py:67: UserWarning: Local correlation is not supported on non-Linux platforms, setting use_custom_corr to False
  warnings.warn("Local correlation is not supported on non-Linux platforms, setting use_custom_corr to False")
C:\Users\dt01yhkwon\Documents\Projects\roma\RoMa\romatch\models\matcher.py:51: UserWarning: Local correlation is not supported on non-Linux platforms, setting use_custom_corr to False
  warn("Local correlation is not supported on non-Linux platforms, setting use_custom_corr to False")
image

@Parskatt Parskatt merged commit 60f9a48 into main Sep 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to install romatch on macOS arm64 due to missing fused-local-corr wheels Setup on Windows

2 participants