Skip to content

Conversation

@webdevinition
Copy link
Contributor

@webdevinition webdevinition commented Oct 17, 2025

Hello @jbtronics,

In relation to #1051 the feature for adding the base of assembly as an new data source.
Also mentioned in the discussion under #1041, section 1.

The changes are the remaining delta to the other extracted feature pull requests related to the mentioned discussion.

2025-10-17 Assembly BOM configuration

Configuration opportunity of Bills of Materials (BOMs) with referencing of other assemblies, cycle prevention included

2025-10-17-Import-assembly oppurtunities

Simplified import overview with template description for filling the parts lists (BOM) of an assembly

2025-10-17-Human readable export

Human-readable export in CSV and PDF format for simplified viewing of basic information

2025-10-17-Human readable export - PDF example

Human-readable export in PDF format to simplify understanding of which parts are actually required for a multiply nested assembly, for example, completely independent of a build function as is the case with projects.

Thanks for everything so far! I am grateful for integration!

Best regards,
Marcel

Marcel Diegelmann added 5 commits December 12, 2025 11:43
Fügt Unterstützung für Assembly-Filter in der Suche sowie ein neues Tab für Assemblies in der Filteransicht hinzu. Anpassungen beinhalten Änderungen an Datenbankabfragen, Formularen und Templates.
Verbessert die Präzision der Übersetzungen für 'assembly_bom_entry' in mehreren Sprachen. Ergänzt neue Label- und Pluralformen in den Dateien sowie zugehörige Zuordnungen in Klassen.
@webdevinition webdevinition force-pushed the feature/assemblies-base branch from 6c29432 to 09738bf Compare December 12, 2025 13:39
@webdevinition
Copy link
Contributor Author

@jbtronics, I've rebased the branch to the master branch.

It would be great if you could take a look at the pull request and give me some feedback on what else needs to be done for you to integrate it.

I wish you even now a nice and fulfilling holiday season!

Best regards,
Marcel

Marcel Diegelmann added 3 commits December 12, 2025 15:05
…ion für Tests aktualisieren

Fügt Standardwerte für autowire und autoconfigure in der Testumgebung hinzu. Markiert EntityExporter als öffentlich und bereinigt die Konstruktor-Definition in der zugehörigen Klasse.
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 28.08151% with 1447 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.85%. Comparing base (98b8c5b) to head (ebb8a2b).

Files with missing lines Patch % Lines
src/Services/ImportExportSystem/BOMImporter.php 14.98% 312 Missing ⚠️
src/Services/ImportExportSystem/EntityExporter.php 3.96% 242 Missing ⚠️
src/Helpers/Assemblies/AssemblyPartAggregator.php 0.74% 133 Missing ⚠️
src/DataTables/AssemblyDataTable.php 0.00% 115 Missing ⚠️
src/Controller/AssemblyController.php 60.13% 61 Missing ⚠️
src/DataTables/AssemblyBomEntriesDataTable.php 62.16% 56 Missing ⚠️
src/DataTables/Filters/AssemblySearchFilter.php 0.00% 56 Missing ⚠️
src/Form/Filters/AssemblyFilterType.php 0.00% 48 Missing ⚠️
...straints/AssemblySystem/AssemblyCycleValidator.php 7.84% 47 Missing ⚠️
...ssemblySystem/AssemblyInvalidBomEntryValidator.php 7.84% 47 Missing ⚠️
... and 32 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1082      +/-   ##
============================================
- Coverage     58.31%   55.85%   -2.47%     
- Complexity     7294     7832     +538     
============================================
  Files           580      607      +27     
  Lines         23207    25180    +1973     
============================================
+ Hits          13534    14064     +530     
- Misses         9673    11116    +1443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant