Update quantity parser in main.js#105
Open
ghuron wants to merge 1 commit intoPascalco:masterfrom
ghuron:patch-2
Open
Update quantity parser in main.js#105ghuron wants to merge 1 commit intoPascalco:masterfrom ghuron:patch-2
ghuron wants to merge 1 commit intoPascalco:masterfrom
ghuron:patch-2
Conversation
Right now it can parse values, that consists solely by figures. But sometimes people put there units of measures as well (such as "16 m", "25 kg", etc. Now we are extracting float from the start of the value
Contributor
|
If the template only allows the parameter to be a number, then it's safe to import as the unit is always the same. However, if the template doesn't enforce the unit, then there's no guarantee the unit corresponds with the chosen one. Therefore, I'm against this change as it's now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now it can parse values, that consists solely by figures. But sometimes people put there units of measures as well (such as "16 m", "25 kg", etc. Now we are extracting float from the start of the value