fix: Address compilation issues in unit tests that were missed by CI #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. Good. The soundness checks are running on this PR. This confirms that they work for normal (non-stacked) PR's targeting |
scottmarchant
force-pushed
the
fix/unitTestCompilation
branch
2 times, most recently
from
2ddadab to
90bff89
Compare
…mbedded doesn't currently compile, which is tracked by #4.
scottmarchant
force-pushed
the
fix/unitTestCompilation
branch
from
90bff89 to
c102fc5
Compare
scottmarchant
changed the title
scottmarchant
changed the title
karloscarweber
approved these changes
Sep 30, 2025
krodak
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the CI didn't run after the final rebase on #2, and these compiler errors due to the rebase weren't caught as a result.
Easy fix.
Also enabling the new wasm native builds.