Show other markers on the map in the edit mode

[circus2271]

#482

[kabalin]

Thanks @circus2271, this needs to be improved:

1. When I edit existing point and move pin to the different location, the original point remains in place:
   
   The current point needs to be excluded from the list of markers.
2. Other displayed points are clickable, it makes very easy to navigate away from editing mode by accidental click on any other point, not sure how critical it is, but I think it is better not to process other point click event while photo is in editing mode (pinging @paul-k-pastvu for opinion).

[circus2271]

@kabalin take a look at 'another draft' commit, please. Is it terribly wrong?

[kabalin]

Thanks for your work @circus2271, see the comments.

[kabalin]

I would suggest instead of looping over markers and disabling event, use this.editing flag (in map controller) in the popupPhotoOver and clickMarker event processing functions in the marker.js (in those functions do not do anything if editing mode is on).

[kabalin]

This does not quite work, if you move editing pin out of screen by dragging the map and then drag it back, the point will be re-added, also this is not ideal to loop over all points every time we editing to find the right point (as pointed earlier). I suggest to refactor this in a way that cid would be used to identify the point. To do this:

1. Keep cid of editing point in map controller object.
2. When editing mode is on, identify current point using photos[cid].marker (markers module) and remove it from layer group (this.markerManager.layerPhotos.removeLayer).
3. When new markers are added as result of panning/zooming map and editing is on, check if newly added point is matching editing cid, if so, do not add it to the layer group.
4. When editing mode is off, add a new point marker only to the layer group, no need to refresh all.

[circus2271]

ok, I'll see

thanks for your feedback

[circus2271]

(пока что отдыхаю)

[kabalin]

Hey @circus2271, are you planning to complete this at any time soon? If not I can take it over and finish (if you don't mind).

[circus2271]

No, I don't mind at all
That would be great, thanks

(I was too lazy to complete it)