More code optimizations, formatting issues, etc#8
Open
MeMyselfMirai wants to merge 5 commits intoPatcailMemer:mainfrom
Open
More code optimizations, formatting issues, etc#8MeMyselfMirai wants to merge 5 commits intoPatcailMemer:mainfrom
MeMyselfMirai wants to merge 5 commits intoPatcailMemer:mainfrom
Conversation
Changelog: - used Arrow / Lambda notation to remove like 100 lines of code - removed toggle.js (merged to script) and challenge.js (merged to layer 3) - modified styles to shorten them. I have no clue how many lines this eradicated.
Expanded all the functions so they look good and are readable at a glance. Also centralized all the effects of the Physical layer upgrades, so they're all in one easily-reached place.
I changed the definition of "inGalChal(x)" so that it can take in any number of parameters, or none at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through the code meticulously and changed a bunch of the code to make it look better. Notably, I removed a ton of redundant lines and later reformatted others such that they look better. Mainly, this involved spacing stuff, using type conditionals and spreading out massive object modifications into multiple lines of if statements, instead of just arbitrary
.timeswith a ternary in it. This probably changed about 60% of the code. I also checked using an endgame save and nothing should break, but if you wanna test it, the code is hosted on https://anthios314.github.io/Time-Layers/