This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Implement ForgeHooks, ForgeEventFactory, etc. #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, every method that I could proxy to EntityEvents and LifecycleEvents has been implemented in ForgeHooks, ForgeEventFactory, BasicEventHooks, and ServerLifecycleHooks.
Contributor
Author
|
Alright, I think that covers the trivial redirects. The question now is, how do we want to handle e.g. events that are already implemented but are dispatched directly from mixins instead of through a class? We could either dispatch the event directly from the hook, or we could reorganize those mixins to call into a class that ForgeHooks also delegates to. |
Member
|
Reorg the mixins to call from a PatchworkXEvents, and then call from there. |
This was referenced Jul 11, 2020
Contributor
Author
|
I'm splitting this into seperate PRs:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't immediately fix the mod listed in #21 as that specific event either doesn't have a method in EntityEvents or isn't implemented yet. Lays some foundataion I guess.
The PR isn't done yet (gotta check the rest of the events modules at least), but I figured I'd get the bikeshed party started early since I've reached a place where it makes sense to pause.