This repository was archived by the owner on Jun 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Impl removedByPlayer and canHarvestBlock in IForgeBlock #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitlith
reviewed
Jul 13, 2020
Contributor
kitlith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic here is somewhat tricky, but looks sound.
If #127 ends up merged before this, can you include the implementation of ForgeHooks.canHarvestBlock?
patchwork-events-world/src/main/java/net/patchworkmc/impl/event/world/WorldEvents.java
Outdated
Show resolved
Hide resolved
...rld/src/main/java/net/patchworkmc/mixin/event/world/MixinServerPlayerInteractionManager.java
Outdated
Show resolved
Hide resolved
...rld/src/main/java/net/patchworkmc/mixin/event/world/MixinServerPlayerInteractionManager.java
Show resolved
Hide resolved
...java/net/patchworkmc/mixin/extensions/block/harvest/MixinServerPlayerInteractionManager.java
Show resolved
Hide resolved
Contributor
Author
Yes of course, and also there are other things that I'm going to add to ForgeHooks and ForgeHooksClient. In all of my PRs, the event dispatch is handled by individual classes, and ForgeHooks is only supposed to be used for accepting Forge mod calls. |
Conflicts: patchwork-events-world/src/main/java/net/minecraftforge/event/world/BlockEvent.java patchwork-events-world/src/main/java/net/patchworkmc/impl/event/world/WorldEvents.java
Conflicts: patchwork-events-world/build.gradle patchwork-extensions-block/build.gradle
TheGlitch76
suggested changes
Aug 2, 2020
...java/net/patchworkmc/mixin/extensions/block/harvest/MixinServerPlayerInteractionManager.java
Show resolved
Hide resolved
patchwork-extensions-block/src/main/resources/patchwork-extensions-block-flammable.mixins.json
Show resolved
Hide resolved
patchwork-extensions-block/src/main/resources/patchwork-extensions-block-harvest.mixins.json
Show resolved
Hide resolved
TheGlitch76
approved these changes
Aug 5, 2020
Member
|
Merge conflicts! |
TheGlitch76
approved these changes
Aug 7, 2020
TheGlitch76
added a commit
that referenced
this pull request
Aug 7, 2020
This reverts commit 7d7f2b1.
TheGlitch76
added a commit
that referenced
this pull request
Aug 7, 2020
This reverts commit 7d7f2b1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getExpDrops will be always called for all blocks, the exp orb drop behavior follows this rule:
Fabric mods does not have a method to get the amount of experience dropped from another block. If a Forge mod calls getExpDrop on a Fabric mod block, it will always get 0. This will be changed once Fabric has something equivalent.
getHarvestTool and getHarvestLevel are stubs, I will impl more tooltype stuff in another pr.