802 add support for automatic foulborn unique tracking by Ivareh · Pull Request #803 · Path-of-Modifiers/pathofmodifiersapp

Ivareh · 2025-11-22T16:01:24Z

No description provided.

bogadisa · 2025-11-22T19:08:29Z

src/backend_api/app/alembic/versions/42c53ebbc633_added_dynamicallycreated_to_modifiers.py

Does nothing

bogadisa · 2026-02-14T17:59:01Z

src/backend_api/app/core/models/init_db.py

This fixes an issue where tables with data inserted from the csv files could conflict/generate way too high id's with existing data in the table. Happens when we delete/updated data, which makes the sequence ids behave weirdly. This will choose current max sequence id, then set the next generating sequence id one up from that.

...ata_retrieval/data_retrieval_app/data_deposit/item_base_type/item_base_type_data/Amulets.csv

bogadisa · 2026-02-14T18:07:29Z

...data_retrieval/data_retrieval_app/data_deposit/item_base_type/item_base_type_data/Armour.csv

No related uniques?

Too much work, there are too many foulborn unques related to every basetype. Needs to be inferred from what's persisted in the database, i.e check what baseTypes is related to which items in Item table, then create relatedUniques from that in basetype table.

bogadisa · 2026-02-14T18:09:21Z

...ckend_data_retrieval/data_retrieval_app/data_deposit/modifier/modifier_data/ThreadOfHope.csv

Potential problem. Passage should probably be a separate modifier

https://www.pathofexile.com/trade/search/Keepers/02np40LeIg

Right now it's currently setup like that (bug probably)

..._data_retrieval/data_retrieval_app/external_data_retrieval/data_retrieval/poe_api_handler.py

...ckend_data_retrieval/data_retrieval_app/external_data_retrieval/detectors/unique_detector.py

bogadisa · 2026-02-15T17:47:37Z

src/backend_api/app/api/routes/carantene_modifier.py

+    ).message
+
+
+@router.post(


delete not post

bogadisa · 2026-02-15T17:49:13Z

src/backend_api/app/crud/extensions/crud_modifier.py

+            )
+            await self.create(db=db, obj_in=modifier_in)
+        else:
+            "I know this shit is messy"


Make it a comment_

bogadisa · 2026-02-15T17:56:40Z

src/backend_api/app/crud/extensions/crud_modifier.py

Why is an "EMPTY" modifier needed?

bogadisa · 2026-02-15T17:58:08Z

src/backend_api/app/crud/base.py

+        deletion_key: str | None = None,
    ) -> ModelType:
-        db_objs = db.query(self.model).filter_by(**filter).all()
+        if isinstance(filter, list) and deletion_key is not None:


can be list, but no deletion key -> big problem

probably fine to remove the deltion_key is not none test

bogadisa · 2026-02-15T18:08:01Z

...ckend_data_retrieval/data_retrieval_app/external_data_retrieval/detectors/unique_detector.py


+class UniqueFoulbornDetector(UniqueDetector):
+    def _check_if_wanted(self, df: pd.DataFrame) -> pd.DataFrame:
+        df_filtered = df[df["identified"] & df["mutated"].astype(str) == "True"].loc[


move all into .loc

bogadisa · 2026-02-15T18:39:58Z

src/backend_data_retrieval/data_retrieval_app/utils.py

        response.raise_for_status()
+
+
+def bulk_update_data(


remove bulk

bogadisa · 2026-02-15T18:44:18Z

...kend_data_retrieval/data_retrieval_app/data_deposit/modifier/carantene_modifier_processor.py

+    return s.split()
+
+
+def _lcs_len(a: list[str], b: list[str]) -> float:


add source? wiki link?

bogadisa · 2026-02-15T18:46:36Z

...kend_data_retrieval/data_retrieval_app/data_deposit/modifier/carantene_modifier_processor.py

+    return dp[m]
+
+
+def _diff_chunks(a: list[str], b: list[str]) -> list[tuple[str, str, int]]:


add comment on where this logic comes from

bogadisa · 2026-02-15T19:00:30Z

...kend_data_retrieval/data_retrieval_app/data_deposit/modifier/carantene_modifier_processor.py

+                                for roll in diff_tuple[:-1]
+                            )
+                        ]
+                        dfx.at[i, "textRolls"] = dfx.at[i, "textRolls"] + diff_rolls


make sure duplicates are not added

bogadisa · 2026-02-15T19:40:51Z

...kend_data_retrieval/data_retrieval_app/data_deposit/modifier/carantene_modifier_processor.py

+        return None
+
+    logger.info(
+        "Its been over 3 days since last created modifiers from carantene modifiers. Retrieving carantene modifiers..."


change 3 with the settings variable

Ivareh added 9 commits October 29, 2025 21:43

#802 added foulborn unique detector

617fd38

#802 added empty name filter

40ddea0

#802 Created carantene modifier models and schemas in api

0cfd2e3

#802 Fix new deposit data modifiers and base types

d9d7d72

#802 New carantene mod schemas and endpoints for handling it in api

682f318

#802 Carantene modifier implementation in data retrieval

687047a

#802 updated grafana schemas

d6e817d

#802 Belts and quivers base types

9a3c3c8

#802 Carantene modifier processor

64909fe

Ivareh requested a review from bogadisa November 22, 2025 16:01

Ivareh assigned Ivareh and bogadisa Nov 22, 2025

Ivareh added backend.Database backend.API backend.new_data labels Nov 22, 2025

Ivareh linked an issue Nov 22, 2025 that may be closed by this pull request

Add support for automatic foulborn unique tracking #802

Open

Ivareh added the backend.Data_retrieval label Nov 22, 2025

Ivareh marked this pull request as draft November 22, 2025 16:02

bogadisa marked this pull request as ready for review November 22, 2025 19:07

bogadisa marked this pull request as draft November 22, 2025 19:07

Ivareh added 6 commits November 22, 2025 22:35

#802 int fix, timestamp filter for textroll and tuning

937120a

#802 grafana remove auth and new dashboard

2ada75d

#802 new base types

83e88f3

#802 carantene modifier init logic

6df4a25

#802 init logic in backend data retrieval for carantene mods

b7ce371

#802 docker env vars and grafana login remove

7dbe08d

bogadisa reviewed Feb 14, 2026

View reviewed changes

Ivareh added 3 commits February 15, 2026 09:03

#802 fixed more base types

89e62e8

#802 added bulk delete api duplicates

4697401

#802 deleted duped grouped car mods in retrieval

9be1053

bogadisa requested changes Feb 15, 2026

View reviewed changes

		return s.split()


		def _lcs_len(a: list[str], b: list[str]) -> float:

		return dp[m]


		def _diff_chunks(a: list[str], b: list[str]) -> list[tuple[str, str, int]]:

		).message


		@router.post(

Conversation

Ivareh commented Nov 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants