Add adjustable URL path for saving sessioninfo as a cookie#71
Open
Boglarka wants to merge 1 commit intoPaulC91:masterfrom
Open
Add adjustable URL path for saving sessioninfo as a cookie#71Boglarka wants to merge 1 commit intoPaulC91:masterfrom
Boglarka wants to merge 1 commit intoPaulC91:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have more shiny applications using the same domain but different URL paths. Therefore I need the authentication cookies to have an adjustable URL path for the cookie to be saved. I set up a fallback/default value ("/") if the new parameter is not set so it does not change the default behaviour of the login procedure.
Sadly I don't know how to test the package with this new code but hopefully everything works as expected.
Please review the modifications and contact me if I can be of any help. Thanks in advance.