Skip to content

Conversation

@ololoshka12345
Copy link

Hi, first of all many thanks for your bindings for libxlsxwriter - i used it at my job for migration of some heavy Excel reports and it worked super great comparing to gem that we used before.
At some point we realized that fast_excel does not have possibility to add styled comments so i added binding for worksheet_write_comment_opt function.
This binding is build with some heavy AI assistance and would be great if someone can CR it and answer on some questions below:

  1. Is it a good practice to set attribute values for Libxlsxwriter::CommentOptions.new using methods but not hash values?
  2. Do i need to define enums for some of attributes defined in Libxlsxwriter::CommentOptions?
  3. Is my current implementation of author and font_name attribute getters/setters in Libxlsxwriter::CommentOptions correct?

There may be a lot of other problems in this PR unknown to me because it's the first time i'm using FFI so would be happy to receive any feedback.

Thanks in advance!

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant