Conversation
Klakurka
requested changes
Jan 14, 2025
Collaborator
Author
|
okay for sure, added those |
Klakurka
requested changes
Jan 15, 2025
Member
There was a problem hiding this comment.
- The dialog height jumping is better but not perfect. We can improve this in a different PR; not high prio.
- If you go to start a shift w/ an editable amount then back out, the 'Edit amount' field will have a ton of extra decimals in there... XEC only supports 2 so I'm not sure where they're coming from:
Notice how the QR code and 'Send' text at the top are fine.
Collaborator
Author
|
hmm yes I'm seeing the same, and actually it will let you enter more than two decimals at any point, as well as non numeric characters... I can see the value it's using, but not sure the best way to fix this. Either way it should probably be handled in another PR. And I think @lissavxo or @chedieck may have a better idea the best way to handle it Its using the "thisamount" value which is not run through the getCurrencyObject function which has some formatting rules based on the currency...I imagine the naked state was used for rendering reasons perhaps?...but seems like the handleAmountChange function could be improved to sanitize the value more |
Klakurka
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related to #442
Description
Test plan
preview and try out a shift