Add Drupal 11 compatibility and fix bugs#12
Open
madsnorgaard wants to merge 1 commit intoPayfast:masterfrom
Open
Add Drupal 11 compatibility and fix bugs#12madsnorgaard wants to merge 1 commit intoPayfast:masterfrom
madsnorgaard wants to merge 1 commit intoPayfast:masterfrom
Conversation
- Add ^11 to core_version_requirement in commerce_payfast.info.yml - Remove broken SiteUrlService from services.yml (class doesn't exist, functionality already in PaymentOffsiteForm::getSiteUrl()) - Fix logger channel from 'your_module' to 'commerce_payfast' in: - OffsiteRedirect.php (3 places) - PaymentOffsiteForm.php (2 places) - Fix uninitialized $storage variable in loadPaymentByRemoteId(): - Initialize $storage = NULL before try block - Add early return FALSE in catch blocks to prevent undefined var error - Add proper use statements for InvalidPluginDefinitionException and PluginNotFoundException Tested on Drupal 11.1.7 with Commerce 3.0 and PHP 8.3. All changes are backwards compatible with Drupal 9.3+ and 10.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Drupal 11 support and fixes several bugs in the commerce_payfast module.
Changes
1. Drupal 11 Support
^11tocore_version_requirementincommerce_payfast.info.yml2. Fixed Broken Service Definition
SiteUrlServicereference fromcommerce_payfast.services.ymlPaymentOffsiteForm::getSiteUrl()3. Fixed Logger Channel Names
Drupal::logger('your_module')toDrupal::logger('commerce_payfast')OffsiteRedirect.php(3 places),PaymentOffsiteForm.php(2 places)4. Fixed Uninitialized Variable Bug
$storage = NULLinitialization before try block inloadPaymentByRemoteId()return FALSEin catch blocks to prevent undefined variable error5. Added Proper Exception Imports
usestatements forInvalidPluginDefinitionExceptionandPluginNotFoundExceptionFiles Changed
commerce_payfast.info.yml- D11 version requirementcommerce_payfast.services.yml- Removed broken servicesrc/Plugin/Commerce/PaymentGateway/OffsiteRedirect.php- Bug fixessrc/PluginForm/OffsiteRedirect/PaymentOffsiteForm.php- Logger fixTesting
commerce_payfastchannelBackwards Compatibility
All changes are backwards compatible with Drupal 9.3+ and 10.x.