Open
Conversation
36208b0 to
625edfb
Compare
- Require PHP ^8.0 - Require Symfony ^5.4 || ^6.0 || ^7.0 || ^8.0 - Remove symfony/polyfill-php80 dependency
Symfony 8 removed XmlFileLoader, requiring PHP-based service configuration. This converts all XML configs to PHP format using ContainerBuilder API.
Symfony 8 removed XML routing support. This converts all routing configuration from XML to YAML format.
- Replace deprecated Request::get() with explicit parameter bag access - Add nullable return type to FormType::getParent() methods - Update CreditCardDate constraint for SF8 named parameter syntax - Add config_sf8.yml for SF8-specific session configuration
- Fix mock class name assertions (Mock_ -> MockObject_) - Update NotifyControllerTest to use request attributes - Exclude abstract test class from phpunit.xml.dist - Remove deprecated PHPUnit config attributes
- Add PHP 8.4, 8.5 with Symfony 7.0 and 8.0 - Remove PHP 7.4 and Symfony 4.4 combinations - Remove Symfony 6.0 (non-LTS, has PHPUnit compatibility issues) - Use --prefer-source for payum/core test classes
625edfb to
7667c5e
Compare
Prometee
suggested changes
Feb 6, 2026
DependencyInjection/Factory/Storage/FilesystemStorageFactory.php
Outdated
Show resolved
Hide resolved
- Use getString() instead of get() for typed parameter access - Use dirname(__DIR__, N) instead of __DIR__.'/..' concatenation
Prometee
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Symfony 8 to PayumBundle.
Changes
Breaking changes:
Symfony 8 compatibility:
CreditCardDateconstraint constructor for SF8 named parameter syntaxNotifyControllerto use$request->attributes->get()instead of deprecated$request->get()HttpRequestVerifierto use explicit parameter bag accessTest fixes:
Mock_→MockObject_)NotifyControllerTestto use route attributes instead of query paramsphpunit.xml.distfor PHPUnit 10+ compatibilityCI Matrix
Now tests against: