Skip to content

Fix Button element and SectionBlock #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Button element and SectionBlock #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b23735
Fix button type element
LuisAntezana Feb 17, 2023
6896da9
Fix text property is null if not set
LuisAntezana Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Peaky.Slack.BlockKit/Elements/ButtonElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public class ButtonElement : IBlockElement
/// <summary>
/// The type of element. In this case type is always button.
/// </summary>
[JsonProperty("button")]
[JsonProperty("type")]
public string Type => "button";

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Peaky.Slack.BlockKit/Layout/SectionBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ public class SectionBlock : ILayoutBlock
/// </summary>
[JsonProperty("type")]
public string Type => "section";

/// <summary>
/// The text for the block, in the form of a text object.
/// Maximum length for the text in this field is 3000 characters.
/// </summary>
[JsonProperty("text")]
[JsonProperty("text", NullValueHandling = NullValueHandling.Ignore)]
public TextComposition Text;

/// <summary>
Expand Down