Skip to content

Remove Sandbox Tests Project.#7

Merged
PearlAegis merged 9 commits intomainfrom
feature/remove-sandbox-tests
Aug 25, 2025
Merged

Remove Sandbox Tests Project.#7
PearlAegis merged 9 commits intomainfrom
feature/remove-sandbox-tests

Conversation

@PearlAegis
Copy link
Copy Markdown
Owner

@PearlAegis PearlAegis commented Aug 24, 2025 •
edited
Loading

Summary

This PR removes the embedded SandboxTests project from the Client solution and adds assembly version synchronization functionality.

Breaking Changes

  • Removed SandboxTests Project: The interactive Blazor test application has been moved to a separate CoinbaseAdvancedTradeClient-Sandbox repository
  • This streamlines the Client project to focus solely on the core library and unit tests

New Features

  • Assembly Version Synchronization: Assembly versions now match package versions for better version tracking
  • Automated Versioning Script: New pack-with-version.sh script handles assembly versioning in CI/CD
  • Enhanced Version Scheme:
    • Release packages (X.Y.Z): Assembly version = X.Y.Z.0
    • RC packages (X.Y.Z-rc): Assembly version = X.Y.Z.1

Technical Improvements

  • CI/CD workflows now set AssemblyVersion, FileVersion, and AssemblyInformationalVersion properties
  • Cleaner GitHub Actions workflows with versioning logic moved to reusable script
  • Assembly.GetName().Version now returns correct package version in consuming applications

Documentation Updates

  • Updated README.md with comprehensive versioning information
  • Enhanced CLAUDE.md with assembly versioning details
  • Added version 0.3.0 to CHANGELOG.md

Testing

  • All 142 unit tests continue to pass
  • Assembly versioning tested in CI/CD pipeline

Test Plan

  • Verify all unit tests pass
  • Confirm solution builds without SandboxTests project
  • Test assembly versioning script locally
  • Validate CI/CD pipeline creates packages with correct versions
  • Ensure documentation accurately reflects changes

🤖 Generated with Claude Code

@PearlAegis PearlAegis changed the title Remove SandboxTests project. Remove Sandbox Tests Project. Aug 24, 2025
PearlAegis and others added 8 commits August 24, 2025 14:06
@PearlAegis @claude
Update documentation after SandboxTests project removal
ca9aabd 
- README.md: Remove references to embedded SandboxTests, point to separate sandbox repo
- CLAUDE.md: Update project structure, commands, and testing references
- CHANGELOG.md: Add breaking change entry for SandboxTests removal

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@PearlAegis @claude
Add assembly version synchronization with package versions.
53c7c49 
- Created pack-with-version.sh script to handle assembly versioning logic
- Updated CI/CD workflows to set AssemblyVersion, FileVersion, and AssemblyInformationalVersion
- Assembly versioning scheme: Release (X.Y.Z.0) vs RC (X.Y.Z.1) builds
- Enhanced documentation in README, CLAUDE.md, and CHANGELOG for version 0.3.0
- Ensures Assembly.GetName().Version returns correct version in consuming applications

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@PearlAegis @claude
Fix script permissions for CI/CD execution.
257795f 
Add execute permissions to pack-with-version.sh to resolve permission denied errors in GitHub Actions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@PearlAegis @claude
Fix line endings and improve pack script reliability.
05bfa56 
- Convert pack-with-version.sh to Unix LF line endings for Linux compatibility
- Fix output directory path (remove ./ prefix)
- Add directory creation to ensure artifacts folder exists

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@PearlAegis @claude
Fix assembly versioning by removing --no-build flag.
735726b 
The --no-build flag prevented assembly version properties from being applied since it used pre-built assemblies. Removing this allows dotnet pack to rebuild with the correct version properties.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@PearlAegis @claude
Move assembly versioning logic to build step with reusable script.
f104f48 
- Created build-with-version.sh script to handle assembly versioning during build
- Updated both PR and release workflows to generate version before building
- Assembly version now set during dotnet build instead of dotnet pack
- Pack script simplified to only handle PackageVersion
- Ensures assembly version is embedded in compiled assemblies

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@PearlAegis @claude
Fix script permissions for build-with-version.sh.
caf8493 
Add execute permissions to resolve permission denied errors in GitHub Actions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@PearlAegis @claude
Fix line endings for build-with-version.sh.
63fcf8e 
Convert from CRLF to LF line endings for Linux compatibility in GitHub Actions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
PearlAegis
PearlAegis commented Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Owner Author

@PearlAegis PearlAegis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, these changes have been reviewed and approved by a human being.
-Pearl

@PearlAegis PearlAegis merged commit fab21c5 into main Aug 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PearlAegis