security: Upgrade CometBFT to v0.37.18 and fix nil validator panic#339
Merged
security: Upgrade CometBFT to v0.37.18 and fix nil validator panic#339
Conversation
- Updates CometBFT from v0.37.15 to v0.37.18 which contains security patches - Fix panic when validator no longer exists during scheduled cork processing (e.g., fully unbonded validators) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughTwo keeper methods (GetApprovedScheduledCorks and GetApprovedScheduledAxelarCorks) now include nil-checks during scheduled cork iteration. When a validator no longer exists, the scheduled cork is deleted, the validator's cork count is decremented, and iteration continues. This prevents processing invalid validator entries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
github.com/cometbft/cometbftv0.37.15 → v0.37.18GetApprovedScheduledCorksGetApprovedScheduledAxelarCorksTest plan
go build ./cmd/...compiles successfullygo test ./x/... ./app/... -shortpasses🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.