Rewrite of the local cache component#3121
Open
bbockelm wants to merge 15 commits intoPelicanPlatform:mainfrom
Open
Rewrite of the local cache component#3121bbockelm wants to merge 15 commits intoPelicanPlatform:mainfrom
bbockelm wants to merge 15 commits intoPelicanPlatform:mainfrom
Conversation
Adds a new local cache codebase which is highly compliant with HTTP 1.1
b7b0535 to
21f5693
Compare
Most important item is the fix for director responses which allowed reuse of a full URL, not just the URL prefix.
- Concurrent range-based downloaders could all try the HEAD in parallel - Have modest retries on metadata update conflicts - Do not cache file descriptors between reads on tests; allows us to reliably change the disk cache from outside the process.
…ndition from updating to the director
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This amounts to approximately a complete rewrite of the local cache component.
The component now implements a wide swath of HTTP 1.1's cache protocol (include
Cache-Control,ETags) and can work at the block level.A much more thorough test suite is included, including work with ETags from the origin.