Fix checksum verification for mismatch algo types#3174
Open
patrickbrophy wants to merge 1 commit intoPelicanPlatform:mainfrom
Open
Fix checksum verification for mismatch algo types#3174patrickbrophy wants to merge 1 commit intoPelicanPlatform:mainfrom
patrickbrophy wants to merge 1 commit intoPelicanPlatform:mainfrom
Conversation
When using an origin backed by the XRootD multiuser plugin, the client would crash with a `strconv.ParseInt out-of-range`error when there was an algorithm mismatch. Additionally, even when the plugin would fallback to a supported algorithm, the client had no way to verify it because the client only computed explicitly requested checksums. Changes: - Compute hashes for all known algorithms during transfer so the client can verify against whatever the server actually returns. - Add length validation for crc32/crc32c parsing to detect and skip mislabled checksums - Extract duplicated verfication logic from downloadObject/uploadObject into a shared helper function. - Request all known checksum types from the server via Want-Digest header to maximize chance of getting supported algorithm - Add unit test for algorithm fallback and mislabeled checksum scenarios. - Add integration test against real multiuser origin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3146
When using an origin backed by the XRootD multiuser plugin, the client would crash with a
strconv.ParseInt out-of-rangeerror when there was an algorithm mismatch. Additionally, even when the plugin would fallback to a supported algorithm, the client had no way to verify it because the client only computed explicitly requested checksums.Changes: