-
Notifications
You must be signed in to change notification settings - Fork 150
Add high contrast visuals into the menu-bar #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
eye icon should be beside the moon icon |
ah ok, ill get done in a bit |
moved, should be ready to merge |
Shouldn't be a window variable, just set it as a attribute to document like dark mode. That way it's easier to apply for css |
oh ok |
anything else that should be done |
Should be it unless you want to make it into a menu that combines dark and contrast mode into 1 dropdown button. |
Personally, I would prefer if we had something like turbowarp's settings menu so we don't clutter the top bar. |
i was gonna do that |
let me familiarize myself with scratch's "Amazing" programming skills (this entire file sucks) |
I agree but this is just a temporary solution till we port over the changes |
idfk how these damn menus work thank you scratch programmers |
i tried and it don't wanna open i hate this codebase |
tdhrjhbsdbsdfjjhgzsd |
i give up on the menu thing |
it should be ready, the css theme="high-contrast" (should be able to) be used to apply to other things like paint and blocks and etc |
There are people who prefer Light Mode over dark mode such as me, but need high contrast visuals.
This PR adds an eye icon beside the language carat icon which toggles high contrast visuals. Additionally, a window variable is applied called "isHighContrast" that the other repos could possibly use to also apply these visuals.