This repository was archived by the owner on Apr 19, 2023. It is now read-only.
Invert tmask to interpolate the correct timepoints#474
Open
dhasegan wants to merge 6 commits intoPennLINC:masterfrom
Open
Invert tmask to interpolate the correct timepoints#474dhasegan wants to merge 6 commits intoPennLINC:masterfrom
dhasegan wants to merge 6 commits intoPennLINC:masterfrom
Conversation
Contributor
Author
|
do I have to change tmask to ones in to: |
Contributor
Author
|
I tested the last version and it correctly processed my volumes (both censored and not). |
Contributor
Author
Contributor
|
that figure is correct for scrubbing outputs. It is necessary to indicate which volumes were flagged, that is why you see c two residual images in regress folder, one without scrubbed volumes and the other with scrubbed volumes |
Contributor
Author
|
I see them, its the Looks good to me. Is there anything else that I should do for this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Discussion is here: #473
I am still debugging this so don't pull this in yet.