Throw exceptions when qdeling non-datums#590
Open
Absolucy wants to merge 4 commits intoPentestSS13:masterfrom
Open
Throw exceptions when qdeling non-datums#590Absolucy wants to merge 4 commits intoPentestSS13:masterfrom
Absolucy wants to merge 4 commits intoPentestSS13:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#90227 and DaedalusDock/daedalusdock#1289
This makes it so passing something that isn't a datum to
qdelwill throw a runtime error, as passing non-datums toqdelresults in immediate, un-queued hard deletes, as seen in a tracy profile of this issue occuring on another codebase:Why It's Good For The Game
Reduces the amount of hard deletes, and unneeded code in general.
Changelog
No player-facing changes.