support configuring exercises by day of the week#474
Merged
garysheng merged 1 commit intoPeonPing:mainfrom Apr 18, 2026
Merged
Conversation
New day-centric schedule config structure:
{
"trainer": {
"exercises": { "pushups": 300, "squats": 300 },
"schedule": {
"mon": { "pushups": 400 },
"sun": { "squats": 0 }
}
}
}
Schedule and uniform goals are mutually exclusive per exercise:
- Setting a day-specific goal removes any uniform goal
- Setting a uniform goal removes any schedule entries
Uses short weekday names: mon, tue, wed, thu, fri, sat, sun
(full names like "monday" are also accepted and normalized)
All 28 trainer tests pass.
|
@garfieldnate is attempting to deploy a commit to the Gary Sheng's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done in a backwards-compatible manner, meaning
you can still use the old uniform (same every day) config, or
you can specify a schedule:
{
"trainer": {
"exercises": { "pushups": 300, "squats": 300 },
// or
"schedule": {
"mon": { "pushups": 400 },
"sun": { "squats": 0 }
}
}
}
At run-time, the schedule value for an exercise is prioritized over any value
for it that might be in the "exercises" object, in the case that both are in the
JSON config. However, from the command line if you set a schedule for
an exercise, then its uniform goal is removed, and vice versa if a uniform goal
is set.
Uses short weekday names: mon, tue, wed, thu, fri, sat, sun (full names like "monday" are also accepted and normalized)
All 28 trainer tests pass. There are some others that fail on my machine, but they're not anything that I touched as far as I can tell.
This was done with Claude. The agent got into some kind of forever-failing
loop related to some Python code getting messed up when piped into the
shell, so I ended up removing two usages of dictionary comprehensions to
get around that.
Fixes #323.