Skip to content

Conversation

@zbx1425
Copy link

@zbx1425 zbx1425 commented Dec 12, 2024

This PR attempts to apply minimal changes to achieve building natively to a NeoForge target, which might appeal to those who don't prefer getting on board a full Sinytra Connector setup just for Continuity or couldn't do that due to compatibility issue.

  • Needed FFAPI components can be JiJ-ed to remove one more dependency (though maybe this can be seen as some overkill, or there might be potential JiJ version conflict issue that needs investigation)
  • Or we can just remove requirement for Sinytra Connector and still require player to separately install FFAPI.


modImplementation("com.terraformersmc:modmenu:${modmenu_version}") {
exclude group: 'net.fabricmc.fabric-api'
// Fetch the version of the fabric-api modules from the pom file
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the sake of JiJ-ing FFAPI, so that it can only JiJ the needed mods.
If it's instead preferred to let players supply FFAPI themselves, this can all be simplified to a modImplementation to the collective FFAPI dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant