Add basic tests for Locks and minor fixes#5
Open
hindenbug wants to merge 1 commit intoPeppertap:masterfrom
Open
Add basic tests for Locks and minor fixes#5hindenbug wants to merge 1 commit intoPeppertap:masterfrom
hindenbug wants to merge 1 commit intoPeppertap:masterfrom
Conversation
Contributor
Author
|
|
monarch/locks.py
Outdated
Contributor
Author
There was a problem hiding this comment.
Timestamp (epoch) makes sense or datetime object ?
Contributor
|
We do some calculation based on the date object in init:throttle() . I am using default serialisation of date object. Which is kind of Json version of this. I think this is what has caused your build to fail. |
hindenbug
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.