Log spam cleanup and XPath patching (on special branch) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Spec requires PatchOperationAttributeAdd to fail if attribute alread exists
Insertion action isn't specified in the PatchOperation spec This implementation inserts it at the end of the list.
This should improve performance, though it does mean arguments have to be explicitly passed into each PatchOperation now. Oh well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from PR #1
Implemented Rimworld style XPath patching. Doesn't currently do any sort of checking if the patches have changed, so after changes users will need to delete the quicklaunch.
Also reduced log spam.
Bonus feature: VSCode configuration for easy IDE work.