Fix: export OOM on large crawls — add streaming export endpoint#48
Open
liquidpurple wants to merge 2 commits intoPhialsBasement:mainfrom
Open
Fix: export OOM on large crawls — add streaming export endpoint#48liquidpurple wants to merge 2 commits intoPhialsBasement:mainfrom
liquidpurple wants to merge 2 commits intoPhialsBasement:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current export flow has a 4× memory multiplication that causes OOM kills
on memory-constrained instances:
For a crawl of ~2200 URLs (~45MB in SQLite), this consistently OOMs on a
2GB RAM instance with systemd MemoryMax.
This PR adds a streaming GET endpoint (/api/export_stream) that uses Python
generators to yield CSV/JSON/XML rows one at a time via Flask Response.
The browser downloads the file directly — no JSON envelope, no Blob,
no round-trip of all data.
The old /api/export_data endpoint is preserved for backward compatibility.
Changes: