Fix empty Links/Issues/Visualization after loading saved crawl#49
Open
liquidpurple wants to merge 1 commit intoPhialsBasement:mainfrom
Open
Fix empty Links/Issues/Visualization after loading saved crawl#49liquidpurple wants to merge 1 commit intoPhialsBasement:mainfrom
liquidpurple wants to merge 1 commit intoPhialsBasement:mainfrom
Conversation
link_manager and issue_detector are None on fresh Crawler instances — they're only initialized during start_crawl(). When load_crawl_into_session() runs, the existing `if crawler.link_manager:` guards silently skip data injection, so loading any saved crawl shows URLs but no links, issues, or visualization edges. This fix initializes LinkManager and IssueDetector before injecting data if they don't already exist, and populates the discovered/visited URL sets so stats display correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link_manager and issue_detector are None on fresh Crawler instances — they're only initialized during start_crawl(). When load_crawl_into_session() runs, the existing
if crawler.link_manager:guards silently skip data injection, so loading any saved crawl shows URLs but no links, issues, or visualization edges.This fix initializes LinkManager and IssueDetector before injecting data if they don't already exist, and populates the discovered/visited URL sets so stats display correctly.