Skip to content

Conversation

@bickelj
Copy link
Contributor

@bickelj bickelj commented Jun 5, 2025

Without this change, it is not clear from whom a PDC Keycloak message comes. With this change, it is a bit clearer and more polite.

Issue #38: Update some email messages in pdc-keycloak-theme

Example email after change

auth_38_admin_email

@bickelj bickelj requested review from jmergy and slifty June 5, 2025 15:20
Copy link
Member

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise this looks good to me (I don't know how to test directly, so rely on you @bickelj to know it's actually functional)

I imagine we'll wait for @jmergy to confirm the content is what it should be.

@bickelj bickelj force-pushed the improve-some-email-messages branch from 42e9129 to e4aa878 Compare June 20, 2025 19:08
Without this change, it is not clear from whom a PDC Keycloak message
comes. With this change, it is a bit clearer and more polite.

Issue #38: Update some email messages in pdc-keycloak-theme
@bickelj bickelj force-pushed the improve-some-email-messages branch from e4aa878 to 8f06db6 Compare July 1, 2025 18:16
@bickelj bickelj merged commit 4c50cb0 into main Jul 1, 2025
2 checks passed
@bickelj bickelj deleted the improve-some-email-messages branch July 1, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants