Expand theme types #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bickelj
force-pushed
the
expand-theme-types
branch
from
f324811 to
609a224
Compare
Contributor
Author
|
There are still some regressions here in the login theme. 
|
bickelj
force-pushed
the
expand-theme-types
branch
from
609a224 to
a6123d7
Compare
This step will help reduce duplication of the same resources across theme types such as "login" and "account." Issue #32 Minimally skin Keycloak account console
These new themes allow use of the common resources. But this does not in itself cause any visual changes to the account or admin areas. Issue #32 Minimally skin Keycloak account console
* Add many of our qualified login styles to generic elements. * Hide some images and/or replace them with PDC images. * Try to get the fonts and colors close. * Keep a copy of PDC logo at old paths to avoid browser cache issue. Issue #32 Minimally skin Keycloak account console
bickelj
force-pushed
the
expand-theme-types
branch
from
a6123d7 to
b60d8aa
Compare
Contributor
Author
|
It looks OK enough in the test environment. I will merge this, build, deploy to test, deploy to prod assuming test still looks good. This way the jar will have been built off the main branch (the very purpose of main). I have verbal approval from @kfogel to skip review here. |
Contributor
|
I had approved, FTR -- just indicated that out-of-band. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are to theme the account and admin areas.
#32 Minimally skin Keycloak account console