Use csv-parse's sync API throughout the scripts
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
More than two years later, no review. We have a different bulk upload strategy now. This may or may not be broken at this point, but I believe it is less broken than that which preceded it. |
Without this change there would be two CSV reading libraries in use and two scripts would continue to have race conditions. We do not need the sophistication of a stream API because we have yet to see any CSVs larger than a few MiB. This change uses the technique already present in the `postProposalVersions.ts` script in the older two scripts. Because there would be repeated boilerplate otherwise, a new `csv.ts` has the commonly used type and type assertion guard. Issue #25 Race between row and EOF events for forms and proposals
bickelj
force-pushed
the
use-csv-parse-sync
branch
from
b107355 to
4e807a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change there would be two CSV reading libraries in use and two scripts would continue to have race conditions. We do not need the sophistication of a stream API because we have yet to see any CSVs larger than a few MiB. This change uses the technique already present in the
postProposalVersions.tsscript in the older two scripts.Because there would be repeated boilerplate otherwise, a new
csv.tshas the commonly used type and type assertion guard.Issue #25 Race between row and EOF events for forms and proposals