Fix the build #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tsup package writes module code to `.mjs` and common to `.js` which is the opposite of what our package.json says. Issue #2 Fix package.json indexes
Member
Author
|
Since this is a fix of a broken build, the fix is simple, and a user is blocked on it, I'm going to hit merge without review. Worst case it's still broken 😬. Oh hey main isn't protected I'll go fix that too! |
hminsky2002
reviewed
Jul 10, 2025
hminsky2002
left a comment
hminsky2002
left a comment
There was a problem hiding this comment.
I know this is now merged but this looks like exactly what was needed to remedy this issue, onus is also on me for not catching this on initial review of the repo setup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our package to point to the actual built file locations.
Later maybe we can figure out how to test the build via CI, but for now we should get this fix out.
Resolves #2