Add auto-imports#79
Open
cgtudor wants to merge 10 commits intoPhilippeChab:migrate-nwnsc-to-nwn-script-compilerfrom
Open
Add auto-imports#79cgtudor wants to merge 10 commits intoPhilippeChab:migrate-nwnsc-to-nwn-script-compilerfrom
cgtudor wants to merge 10 commits intoPhilippeChab:migrate-nwnsc-to-nwn-script-compilerfrom
Conversation
cgtudor
changed the base branch from
main
to
migrate-nwnsc-to-nwn-script-compiler
cgtudor
force-pushed
the
auto-imports
branch
2 times, most recently
from
e34403c to
2eeb1f1
Compare
… exiting early on the first one (so everything is underlined instead of having to solve one, save, solve the next)
cgtudor
force-pushed
the
auto-imports
branch
from
2eeb1f1 to
577d24e
Compare
Now, we prioritize functions with bodies and only jump to forward declaration if no full function was found. This also means there's no reason for forward declarations anymore.
cgtudor
force-pushed
the
auto-imports
branch
from
577d24e to
fac9e8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #78 but I can't set that as the base branch on this repo.
This adds two new functionalities to the LSP:
From a UX perspective, these are meant to mimick functionality from modern IDEs which allow you to do very much the same (vscode included) for normal languages.
Note: imports are added after the last import statement in the file if it exists. If it doesn't, they are added at line 0.
From my testing it seems to work great, and I don't see a performance dip either.