Add GitHub workflow for multi-platform builds#282
Open
thaddeuskkr wants to merge 1 commit intoPhineas:mainfrom
Open
Add GitHub workflow for multi-platform builds#282thaddeuskkr wants to merge 1 commit intoPhineas:mainfrom
thaddeuskkr wants to merge 1 commit intoPhineas:mainfrom
Conversation
Signed-off-by: Thaddeus Kuah <tk@tkkr.dev>
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub Actions workflow intended to build and publish multi-platform Docker images (amd64 + arm64) for Lanyard, replacing the existing single-arch Docker workflows.
Changes:
- Introduces a
docker-bake.hclconfiguration with targets for local and multi-platform builds. - Adds a new consolidated workflow (
.github/workflows/docker.yml) that builds per-platform images and merges them into a multi-arch manifest. - Removes the previous Docker build/push workflows (
docker-image.yml,docker-build.yml).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
docker-bake.hcl |
Adds bake targets for local and multi-platform builds. |
.github/workflows/docker.yml |
New CI workflow for building/pushing per-platform images and creating a manifest list. |
.github/workflows/docker-image.yml |
Removes prior push-on-main workflow. |
.github/workflows/docker-build.yml |
Removes prior PR build workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an updated version of #258 (my own previous PR). The self-hosted version of Lanyard currently only runs on
amd64servers. This PR adds multi-platform builds using GitHub-hosted runners, which allows Lanyard to be self-hosted on a wider variety of servers, especially as ARM increases in popularity. It specifically targets the following platforms, but more can be added in the future:linux/amd64linux/arm64This PR should be able to be merged without any additional changes to the repository - it uses the existing Docker secrets that are already used in the previous version of the workflow.
I've tested the build process on my own branch, this can be found here. Additionally, I'm running the ARM64 container on my own instance of Lanyard (available here).
Merging this PR also resolves #244.
Docker Hub Images: https://hub.docker.com/r/thadkkr/lanyard