Skip to content

FIX: printLog write error handle #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pho3b merged 2 commits into from
Nov 24, 2025
Merged

FIX: printLog write error handle #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7b82f5
fix: printLog write error handle
iamAdityafr Nov 23, 2025
3eeadfa
refactor: only prints the error to the stderr if printLog method fails
Pho3b Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions logs/encoders/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,18 +82,24 @@ func (b *baseEncoder) castToString(arg any) string {
// printLog prints the given msgBuffer to the given outputType (stdout or stderr).
// If 'file' is not nil, the message is written to the file.
func (b *baseEncoder) printLog(outType s.OutputType, msgBuffer *bytes.Buffer, file *os.File) {
var err error

switch outType {
case s.StdOutput:
_, _ = os.Stdout.Write(msgBuffer.Bytes())
_, err = os.Stdout.Write(msgBuffer.Bytes())
case s.StdErrOutput:
_, _ = os.Stderr.Write(msgBuffer.Bytes())
_, err = os.Stderr.Write(msgBuffer.Bytes())
case s.FileOutput:
if file == nil {
_, _ = os.Stderr.Write([]byte("error: file is nil"))
_, _ = os.Stderr.Write([]byte("tiny-logger-err: given out file is nil"))
return
}

_, _ = file.Write(msgBuffer.Bytes())
_, err = file.Write(msgBuffer.Bytes())
}

if err != nil {
_, _ = os.Stderr.Write([]byte("tiny-logger-err: " + err.Error() + "\n"))
}
}

Expand Down