Skip to content

[DRAFT] Update digital-only trigger mode with proof of concept impl#97

Open
trstruth wants to merge 2 commits intoPhobGCC:mainfrom
trstruth:trstruth/digital-trigger
Open

[DRAFT] Update digital-only trigger mode with proof of concept impl#97
trstruth wants to merge 2 commits intoPhobGCC:mainfrom
trstruth:trstruth/digital-trigger

Conversation

@trstruth
Copy link
Copy Markdown

@trstruth trstruth commented Oct 12, 2023

In the current implementation of digital only trigger mode, analog trigger inputs are disabled entirely, while digital trigger inputs are preserved. I want a new trigger mode called "exclusive digital" or something of the sort which results in a digital trigger input when any analog value above some low threshold is read.

I want this because

  • I want to powershield falco lasers more consistently.
  • I want to avoid ADT.
  • I can't use the current implementation of digital only because I shield drop by only pushing the trigger in half way, and I shield drop and power shield with the same trigger.

I flashed the contents of this branch onto my phob and I get the desired behavior: when I change my trigger mode to 2, I can slightly hold down the trigger and I get a digital full shield every time. Here's a visual demonstration of the behavior as seen through smashscope (the mode is enabled for the right trigger, while the left trigger is still in the default mode):

digital_trigger

As the title suggests this is still in a draft state, and to be considered complete I think the following changes should be made

  1. Create a new trigger mode, as opposed to replacing the existing "digital only" mode.
  2. Allow the threshold (currently hardcoded to 10) to be configurable, similar to some of the other modes.

Is this a feature that would get merged? Does anyone have concerns/comments with the above proposal?

netai and others added 2 commits October 12, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant