[DRAFT] Update digital-only trigger mode with proof of concept impl#97
Open
trstruth wants to merge 2 commits intoPhobGCC:mainfrom
Open
[DRAFT] Update digital-only trigger mode with proof of concept impl#97trstruth wants to merge 2 commits intoPhobGCC:mainfrom
trstruth wants to merge 2 commits intoPhobGCC:mainfrom
Conversation
… to trigger modes, use modulo instead of if/else for incrementing trigger modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation of digital only trigger mode, analog trigger inputs are disabled entirely, while digital trigger inputs are preserved. I want a new trigger mode called "exclusive digital" or something of the sort which results in a digital trigger input when any analog value above some low threshold is read.
I want this because
I flashed the contents of this branch onto my phob and I get the desired behavior: when I change my trigger mode to 2, I can slightly hold down the trigger and I get a digital full shield every time. Here's a visual demonstration of the behavior as seen through smashscope (the mode is enabled for the right trigger, while the left trigger is still in the default mode):
As the title suggests this is still in a draft state, and to be considered complete I think the following changes should be made
Is this a feature that would get merged? Does anyone have concerns/comments with the above proposal?