Explicitly handle Sim Camera params in milliseconds#2375
Open
cswilson252 wants to merge 3 commits intoPhotonVision:mainfrom
Open
Explicitly handle Sim Camera params in milliseconds#2375cswilson252 wants to merge 3 commits intoPhotonVision:mainfrom
cswilson252 wants to merge 3 commits intoPhotonVision:mainfrom
Conversation
github-actions
bot
added
the
photonlib
cswilson252
commented
Feb 24, 2026
samfreund
reviewed
Feb 25, 2026
| * published) a frame should have | ||
| * published) in milliseconds a frame should have | ||
| */ | ||
| void SetAvgLatency(units::second_t avgLatency) { |
Member
There was a problem hiding this comment.
looks like this function here is still in seconds?
Contributor
Author
|
IIRC C++ rounds this to .01 as it’s a double. and I was told to focus more on Python and Java equivalency here :)On Feb 25, 2026, at 3:26 PM, Sam Freund ***@***.***> wrote:
@samfreund commented on this pull request.
In photon-lib/src/main/native/include/photon/simulation/SimCameraProperties.h:
@@ -107,7 +107,7 @@ class SimCameraProperties {
* Sets the simulated latency for this camera.
*
* @param avgLatency The average latency (from image capture to data
- * published) a frame should have
+ * published) in milliseconds a frame should have
*/
void SetAvgLatency(units::second_t avgLatency) {
looks like this function here is still in seconds?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
mcm001
reviewed
Feb 26, 2026
| * | ||
| * @param avgLatency The average latency (from image capture to data | ||
| * published) a frame should have | ||
| * published) in milliseconds a frame should have |
Contributor
There was a problem hiding this comment.
Suggested change
| * published) in milliseconds a frame should have | |
| * published) a frame should have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed? Why? (the code + comments should speak for itself on the "how")
Closes #2003, converts seconds to milliseconds in Python's
simCameraProperties.py. These were always supposed to be inms, this just explicitly specifies that in order to cause less confusion.Meta
Merge checklist: