First push of prostate project files #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
vincent-noel
reviewed
Sep 1, 2025
Member
There was a problem hiding this comment.
Hi Arnau !
First of all, thanks for taking the time. Everything seems to work fine, except the death phases duration definition, which were using the old format. Somehow it doesn't crash when used for cell cycle, but do crash when defined for death (@rheiland ?)
If you think it' ok, accept the changes and I'll already create the repo.
vincent-noel
reviewed
Sep 1, 2025
Member
vincent-noel
left a comment
vincent-noel
left a comment
There was a problem hiding this comment.
This old format of defining phases rates (instead of durations) for death model crashes in studio.
Co-authored-by: Vincent Noël <contact@vincent-noel.fr>
Co-authored-by: Vincent Noël <contact@vincent-noel.fr>
Co-authored-by: Vincent Noël <contact@vincent-noel.fr>
Co-authored-by: Vincent Noël <contact@vincent-noel.fr>
Co-authored-by: Vincent Noël <contact@vincent-noel.fr>
Co-authored-by: Vincent Noël <contact@vincent-noel.fr>
Co-authored-by: Vincent Noël <contact@vincent-noel.fr>
Co-authored-by: Vincent Noël <contact@vincent-noel.fr>
Contributor
Author
|
I agree with the changes, thanks for the review! |
vincent-noel
reviewed
Sep 3, 2025
Member
vincent-noel
left a comment
vincent-noel
left a comment
There was a problem hiding this comment.
Two more things now that I had a better look
vincent-noel
force-pushed
the
main
branch
3 times, most recently
from
af8dccc to
e7bf76b
Compare
Member
|
Good for me, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This repository is an update of the prostate model to version 2.2.3 of PhysiBoSS.
Checklist
Does your model compile on all os ?
I have only tested it on Linux
Have you informed the metadata file (model.yml)
Have you written a README.md file ?
Do you accept to become a maintainer of this model
Yes, who else? ;p