WIP: Refactor analytics #197
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
fxjung
force-pushed
the
refactor_analytics
branch
from
44cf990 to
04414f2
Compare
This comment has been minimized.
This comment has been minimized.
fxjung
force-pushed
the
refactor_analytics
branch
from
04414f2 to
162800b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* some analytics things, graph distance cache size increased * added external cost, renamed class to cls/lower cased some things * fixed some bugs * more analytics stuff * formatting * fixed analytics bug where the avg stoplist length was computed incorrectly, and cython continuous space bug, where the coord_range was not pickled * seat capacity and idling duration * non-analytics tests fixed * fixed the analytics test for now, still needs heavy refactoring, see #204 * comment removed * added old file from other branch
fxjung
force-pushed
the
refactor_analytics
branch
from
659952c to
1a16316
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be updated (i.e. rebased), as there have been some recent changes to the analytics module that partially resolve what was done here.