Skip to content

Conversation

@fxjung
Copy link
Member

@fxjung fxjung commented Nov 29, 2024

  • Added the option for the Euclidean2D space to have periodic boundaries
  • Added analytics function compute_transient_controlled_system_quantities
  • Commented the C++ dispatcher a bit better

WARNING

This PR currently introduces a new bug. I don't understand the actual reason yet, but all <sim_id>_params.json files have velocity: 1 for their space. This must somehow be a consequence of having added the boundary condition kwargs, probably the serialization is broken.

Although this produces the correct output:

from ridepy.extras.io import ParamsJSONEncoder
import json

print(json.dumps({'space': space}, indent=4, cls=ParamsJSONEncoder))

@fxjung fxjung requested a review from debsankha as a code owner November 29, 2024 15:50
@github-actions
Copy link

github-actions bot commented Nov 29, 2024

Unit Test Results

121 tests  +1   117 ✅ +1   51s ⏱️ -1s
  1 suites ±0     4 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit caacee3. ± Comparison against base commit 41b9085.

♻️ This comment has been updated with latest results.

@fxjung fxjung closed this Jun 11, 2025
@fxjung fxjung deleted the analytics-transient-removal branch June 11, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants