Control for transients in the analytics module #274
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Euclidean2Dspace to have periodic boundariescompute_transient_controlled_system_quantitiesWARNING
This PR currently introduces a new bug. I don't understand the actual reason yet, but all
<sim_id>_params.jsonfiles havevelocity: 1for theirspace. This must somehow be a consequence of having added the boundary condition kwargs, probably the serialization is broken.Although this produces the correct output: