feat: Legacy .schematic support, Batch Converter, and Thumbnail Fixes#24
feat: Legacy .schematic support, Batch Converter, and Thumbnail Fixes#24Larson-Logan wants to merge 24 commits intoPiTheGuy:masterfrom
Conversation
- Added LegacyMappings to convert between Block IDs and modern BlockStates. - Implemented ClassicSchematicFormat for reading and writing .schematic files. - Updated Schematic class to support the .schematic extension and fixed missing getters. - Registered the new format in SchematicFormats. - Added legacy_mappings.json resource file. - Verified functionality with tutorialtrees.schematic test case.
The README has been updated to include new features.
PiTheGuy
left a comment
PiTheGuy
left a comment
There was a problem hiding this comment.
There's a lot of extraneous formatting changes in this PR that make it more difficult to review.
Also, I'm not sure a seperate executable is the right approach for batch coversion. I think it would be better to implement in the main app. It already mostly has been, but it could do with a few improvements like supporting folders rather than just a list of files.
| return sb.toString(); | ||
| } | ||
|
|
||
| public static int getInt(Tag tag) { |
There was a problem hiding this comment.
CompoundTag already has getInt and getDouble methods. If we're going to improve reading, I think it would be better to do it there.
|
I'm interested in the legacy .schematic file conversions for Minecraft 1.12. https://puregero.github.io/SchemToSchematic/ Alas, if the blocks didn't exist in 1.12 they are replaced with air blocks. So perhaps a converter isn't really worth it unless you were able to tell the program to replace with the closest relative of the missing block. Minecraft 1.12 Block IDs |
3 participants
Summary
This PR implements several major requested features and improvements to the converter:
.schematic(MCEdit/Classic WorldEdit) format. This allows conversion from and to the old format.src/scripts/convert_all.pyand a build scriptscripts/build_executable.batto allow users to mass-convert entire folders of schematics recursively.Schematicclass andAxiomSchematicFormatto correctly read and preserve embedded preview images (thumbnails) when converting Axiom.bpfiles.README.mdwith instructions for the new Batch Converter tool.Resolves Issues
Changes
New Files:
src/main/java/pitheguy/schemconvert/converter/formats/ClassicSchematicFormat.javasrc/main/java/pitheguy/schemconvert/converter/LegacyMappings.javasrc/scripts/convert_all.pysrc/scripts/build_executable.batModified:
src/main/java/pitheguy/schemconvert/converter/Schematic.java: Addedthumbnailfield and builder support.src/main/java/pitheguy/schemconvert/converter/formats/AxiomSchematicFormat.java: Added logic to read/write embedded thumbnails.README.md: Added Batch Converter usage guide..gitignore: Added build artifacts.Verification
./gradlew build..schemto.schematicsuccessfully.convert_all.exegenerated by the batch script..bpfiles.