Skip to content

[ros2] Fix derived searchPositionIK function definition#15

Open
mechwiz wants to merge 1 commit intoPickNikRobotics:ros2from
mechwiz:remove_override
Open

[ros2] Fix derived searchPositionIK function definition#15
mechwiz wants to merge 1 commit intoPickNikRobotics:ros2from
mechwiz:remove_override

Conversation

@mechwiz
Copy link
Copy Markdown

@mechwiz mechwiz commented Jan 26, 2023

I was getting the following compilation error about thesearchPositionIK function below saying its suppose to override the one in kinematics::KinematicsBase but it's not. Turns out that the function defintion was ever-so-slightly different from the base class version. This PR fixes it.

bio_ik/src/kinematics_plugin.cpp:367:3: error: ‘bool bio_ik_kinematics_plugin::BioIKKinematicsPlugin::searchPositionIK(const std::vector<geometry_msgs::msg::Pose_<std::allocator<void> > >&, const std::vector<double, std::allocator<double> >&, double, const std::vector<double, std::allocator<double> >&, std::vector<double, std::allocator<double> >&, const IKCallbackFn&, kinematics::KinematicsBase::IKCostFn, moveit_msgs::msg::MoveItErrorCodes&, const kinematics::KinematicsQueryOptions&, const moveit::core::RobotState*) const’ marked ‘override’, but does not override
  367 |   searchPositionIK(const std::vector<geometry_msgs::msg::Pose>& ik_poses, const std::vector<double>& ik_seed_state,
      |   ^~~~~~~~~~~~~~~~
gmake[2]: *** [CMakeFiles/bio_ik_plugin.dir/build.make:160: CMakeFiles/bio_ik_plugin.dir/src/kinematics_plugin.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:185: CMakeFiles/bio_ik_plugin.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< bio_ik [11.3s, exited with code 2]
``

@mechwiz mechwiz changed the title [ros2] remove override [ros2] Fix derived searchPositionIK function definition Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant