Reset trajectory generator after instantiating object#10
Open
zultron wants to merge 1 commit intoPickNikRobotics:works_may17_2020from
Open
Reset trajectory generator after instantiating object#10zultron wants to merge 1 commit intoPickNikRobotics:works_may17_2020from
zultron wants to merge 1 commit intoPickNikRobotics:works_may17_2020from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch calls the
TrajectoryGenerator.reset()method after the constructor, resetting the underlyingSingleJointGenerator()object. The latter's constructor no longer does that itself, and requires its own, separatereset()now.This patch won't break those running TJ versions before these changes; the
reset()will simply be redundant.This work is still ongoing, and will change again, but this patch is required for testing the recent TJ changes in a MoveIt planning pipeline.
Checklist