changing success count after ControllerSwitch so mpc pose tracking objective runs#497
Merged
marioprats merged 1 commit intomainfrom Feb 6, 2026
Merged
changing success count after ControllerSwitch so mpc pose tracking objective runs#497marioprats merged 1 commit intomainfrom
marioprats merged 1 commit intomainfrom
Conversation
bkanator
changed the title
marioprats
approved these changes
Feb 6, 2026
marioprats
left a comment
marioprats
left a comment
There was a problem hiding this comment.
Makes sense, thanks Breelyn!
MPC still needs the JTC unfortunately, so we have to explicitly enable it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-open pr that was closed due to josh's large example ws change.
Looks like a SwitchController behavior got added to the objective which causes the mpc optimization to not run since the parallel success count was set to 1. Bumping it to 2 so it will run optimization.
Unsure if this is the correct fix so asking for eyes from @marioprats since he added the new SwitchController behavior to this objective last week.