Fix deprecation issues, rename func publishMarkersWithoutTrigger()#123
Open
davetcoleman wants to merge 1 commit intomasterfrom
Open
Fix deprecation issues, rename func publishMarkersWithoutTrigger()#123davetcoleman wants to merge 1 commit intomasterfrom
davetcoleman wants to merge 1 commit intomasterfrom
Conversation
Member
davetcoleman
commented
Aug 14, 2019
davetcoleman
commented
- Switch to C++14 deprecation approach
Member
Author
|
@simonschmeisser this is per your suggestion |
davetcoleman
force-pushed
the
deprecation_stuff
branch
from
60e2b19 to
926dc21
Compare
- Switch to C++14 deprecation approach
davetcoleman
force-pushed
the
deprecation_stuff
branch
from
926dc21 to
9f7cdf5
Compare
Member
Author
|
@simonschmeisser could you approve please? |
simonschmeisser
approved these changes
Aug 21, 2019
Contributor
simonschmeisser
left a comment
simonschmeisser
left a comment
There was a problem hiding this comment.
I think the name could be improved, from an outside point of view you don't expect the caching/triggering to be necessary. So maybe 'actuallyPublishMarkers' or 'directlyPublishMarkers' or 'publishMarkersDirectly'?
Greetings from the Italian alps, this is a smartphone review :)
mlautman
approved these changes
Jan 27, 2020
tylerjw
approved these changes
Nov 16, 2020
Contributor
tylerjw
left a comment
tylerjw
left a comment
There was a problem hiding this comment.
This looks good, should be rebased first before it can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.